Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Common Runtime Tests for Mono on Linux-Arm64 in CI #35366

Merged
merged 17 commits into from
May 9, 2020

Conversation

naricc
Copy link
Contributor

@naricc naricc commented Apr 23, 2020

Enable runtime tests on Linux Arm-64 with Mono.

@ghost
Copy link

ghost commented Apr 23, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@naricc naricc changed the title Enable Common Runtime Tests for Mono on more architectures Enable Common Runtime Tests for Mono on more architectures in CI Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
author David Wrighton <davidwr@microsoft.com> 1588796813 -0700
committer Nathan Ricci <naricc@microsoft.com> 1588797987 -0400

parent b70309a
author David Wrighton <davidwr@microsoft.com> 1588796813 -0700
committer Nathan Ricci <naricc@microsoft.com> 1588797985 -0400

parent b70309a
author David Wrighton <davidwr@microsoft.com> 1588796813 -0700
committer Nathan Ricci <naricc@microsoft.com> 1588797980 -0400

parent b70309a
author David Wrighton <davidwr@microsoft.com> 1588796813 -0700
committer Nathan Ricci <naricc@microsoft.com> 1588797960 -0400

Added ci lane for linux-arm64 on mono.

More updates to issues.targets

Removed whitespace changes, again.

Remvoed trailing whitespace.

More indentation fixes.

Added more archs for runtime tests.

undo unecessary changes.

Changed list of architectures to prioritize most important ones.

Added build for Linux_arm libraries.

got rid of extra arm build.

Added linux_arm, linux_arm64 debug library builds.

remvoed extra arm64 libraries build.

White space.

Removed white space.

Switched to release version of libraries.

Always adding RuntimeFlavor to the libs builds

Changed arm.

Changed where arm is built.

Changed where arm is built.

Moved arm back to release build only.

Added upper case version of liveLibraryBuildConfig.
@naricc naricc force-pushed the naricc/more-arcs-runtime-tests branch from 0f907e9 to a023c6f Compare May 6, 2020 20:47
@naricc naricc marked this pull request as ready for review May 7, 2020 15:21
@naricc naricc requested a review from safern May 7, 2020 15:22
@naricc naricc assigned trylek and unassigned trylek May 7, 2020
@naricc naricc requested a review from trylek May 7, 2020 15:22
@naricc naricc changed the title Enable Common Runtime Tests for Mono on more architectures in CI Enable Common Runtime Tests for Mono on Linux-Arm64 in CI May 7, 2020
@naricc
Copy link
Contributor Author

naricc commented May 7, 2020

I still need to add exclusions to issues.targets for linux arm64, but the logic is otherwise right and I thought I should start reviews.

@safern
Copy link
Member

safern commented May 8, 2020

@jashook this will add another test run in Linux_ARM64, so just to be aware and on the lookout for any ARM64 slowdown on our test runs.

@naricc naricc closed this May 9, 2020
@naricc naricc reopened this May 9, 2020
@naricc naricc merged commit d2f7c8f into dotnet:master May 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants